Conversation
fwiesel
force-pushed
the
offboarding-hypervisor
branch
from
4d6caf2 to
36f897c
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
- Block gardener with pdb until offboarded - Communicate offboarded via condition on hypervisor - Do only decomissioning via hypervisor cro Use offboarded instead of decomissioning as it is clearer the opposite from onboarding.
notandy
approved these changes
Jan 27, 2026
Contributor
notandy
left a comment
notandy
left a comment
There was a problem hiding this comment.
LGMT, I also like to use Positive = True Conditions - having Conditions only false if they signal a transient state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use offboarded instead of decomissioning as it
is clearer the opposite from onboarding.